XWidgetSoft Forum

I would like to port this cool design for Android for XW.. (without the weather,battery,message function)
I have already started but I need a couple of suggestions/help with the script..

1) I was thinking to make an animated png for the "arm", so when you press the "play" button the arm will be over the disk and with "pause" or "stop" the arm turns in the initial position.
So I need this script but also an "invert" function (the default "invert" option of the designer doesn't help)

2) At the same time I made the "cover" disc like an animated png, so the disc it turns, but on play the cpu is ~20-25%. So I would like to add an option to give the possibility to the user to choose if wants this animation during play or not..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

it shouldn't be so hard
i think it only needs rotating image in the script, no need for animation effect
the code will be like the raindrop widget
waiting to see the parts to try it out...

Here is what I have done so far..

So for the arm, I should use a "rotator" component and you can control it though script to give a certain angle during play/stop?
And same for the disc? Transform it to a normal "image" that will move tough script..?

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

i have never thought of rotator Object,
in script we can use any object for rotation, since all of them have the rotate option in their properties
rotator object have some extra options in its properties for this
in script we can create manually these features too

so it's your choice to choose which one to use based on your design
also for multiple object to rotate together we can add all of them to one Object and rotate that Object only

Changes:
- I changed the disc from "animatedpng" to normal "image" since we can use any object for rotation through script.. (I hope we can earn less cpu usage..!)
- I changed the arm using a rotator to see its movement (check the "start/end angle")

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

the disc rotation will have a high cpu usage (for me 15-25%)
since it's a large image, it will have more cpu usage than others
i don't think we can even create a gif for this one
since it's coverart and should change for each track, right?

Yes... I was hoping changing the component from animatedpng to simple image, we can have less cpu usage..
That's why in my first post I wrote that we can add a right click option so the user can choose to turn on this extra animation or not..

About the arm movement on play..?

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

ok, a new test version available:

========
Changes:
changed: arm Object from rotator to image
Added: Script for rotation
Added: 3 timerCore to Execute the script
============


it will have high CPU usage
you can lower the usage for disc rotation by changing update time in timerrotate timerCore
but then it will not be like a real disc rotate

i have got an idea,
how about having an option to choose disc cover: mini, full, none
and also we can have DiscBoxCover somewhere else in fullsize as static image

Hmm...Is all about the cpu usage, or just add some extra option?
For the DiscBoxCover, I don't know where we can place it... I would like to keep this design..

edit:
Now let me complete the designing part adding all the rest elements of a music player and make it functional..
I will post it as soon as possible..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

by lowering the dimensions of image object the cpu usage wilt get lower
so to save the design we can make image object smaller to be as a miniDisc

we can add a slider on one of the side of player,
i think right or bottom is good for it
the slider can be slided by mouseclick/mouseleave or mouseenter/mouseleave

Let me see what I can do...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

Here is the full functional widget (ready to use).
It's only missing the "DiscBoxCover slider" (I will add it in the test next version)
Test the widget and tell me your opinion..

(to change the vol. click once on the circle meter and use the mouse wheel)

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

ideas:
1. how about having hint on mouseover buttons?
2. and i was thinking to make the arm go start to end by playing percent, how about this?

problems:
1. why volume needs clicking to be active for changing?
2. mute and unmute icons isn't vice versa?

1. The icons are pretty readable and clear about their function, so I don't think is necessary.
2. I didn't know that is possible so yes it will be Awesome! (if this will not increase the cpu)

1. The Roundline is on top but seems that works only like this (depends on XW)
This happens only with rounline. When you have an image with vol control assigned works without click:
http://jimking.deviantart.com/art/Indic ... -434611845
2. No the icons should be like this:
Button UN-Checked image = Sound ON (default without click on it)


Button Checked image = Sound OFF


Edit:
What about the cpu usage with the rotation of the disc? Are you sure that using an "image" is better than an animatedpng..?

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

i just hit an icon that i don't know and it opens a webpage, and then i found its coverfinder,
so i think having it would be better



i don't think it have effect on cpu usage, but i should see after done



we can assign the mouse event to another object and do increase/decrease through it in code



can you test it on widget execution?
i think it should be vice versa


i think the cpu usage is high because the drawing of an image with big dimension with that update time uses cpu more,
if you place the image object out of widget sight, you will see that the cpu usage get lower (maybe get zero)
so we can't do anything about it (we can only adjust update time and how much to go on each update)

about png i didn't test it with that, but i don't think it will be different
you can test it yourself easily by changing image object to png object in XUL file

I prefer not to add "hints" on the buttons.. Instead I can put text/titles on the right corner (below the buttons) that will appear on mouse over the icons.

Ok...

Ok..But I don't think is a big deal click one click before you change the volume..

I checked (see screenshot)

I tested on my first test widget and with animpng I received ~20-25% cpu usage.
It's not sooo big.. That's why I told you that it will be ideal aright click option to turn on/off the disc rotation..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

plz test it when running the widget,
when you run the widget:
when the mute image is shown: volume is on
when the unmute image is shown: volume is off


edit:
why don't you add player's volume up/down instead of main-volume up/down

Test results:

I tested hamid more than once. For me is shown as it should!
Sound ON (default, when the widget is loading/startup)

Sound OFF


Using the volumecore and open the tags I see only codes for the main volume..
I use this mode for all my "player" widgets..

The problem is other:
* The "playtime" txt, prev,next,play/pause buttons, progressbar don't work.
* Not playback! The player in general doesn't work.

EDIT:
Let's me see what the f... is happening because something wrong with the XW and the windows music folder...
I have to restart XW and maybe windows...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

Look what is happening (using XWidget with ONLY this widget on desktop and after reboot of Windows)
* CPU usage ~55-70% (too high!)
* Results? The progress bar, playtime don't update, the next/prev button during play not always work.
Even the XW I think is unable to load in memory the sounds/songs with this cpu.
I had to open the WMP first to make it play.
* The Mute button works ok.

At this point we have try this:Post another test file removing the rotating mode for the disc and add animpng with the simple script
"onplayback=play animpng/stopplayback=stop play animpng"

Can you do this..? Give me some time to replace the "image", add a right click option to "add song" for test better, add txts/titles for the buttons like "hints"..

We will give this last try, and if this doesn't work either, I think that we have abbandon the idea of the rotating disc... Damm!

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

Something is wrong with my XW.. I'm trying other player widgets but I have the same behavior,so don't work!!! Any ideas..?
I have to open the WMP first and then the player widgets work.... WTF?! This is the first time that I have this problem.....
Tested again only with this player widget (and the WMP open) the cpu changes/depends a lot on the cover's image as we told..
I will try to completely shutdown the system/laptop because the reboot didn't help...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

the problem is if you start widget when volume is mute then it will be vice versa
because it doesn't check the mute state
also it doesn't change if you change the mute from system (not widget)

1. to fix it you should use a button with icons and %mute tag in it and OnClick event to !SetMute
2. the PlayerCore has its own %mute and %volume tags and also !Mute and !VolumeUP/!VolumeDown Commands for controlling players state not systems state;
plz use them instead

try to taskkill wmplayer.exe

Another bug of synchronization of the XW then..(?)

Ok..I will edit it..

You're right! I completely forgot it...

I will post the next test version as soon as possible...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

I notice that the wmplayer.exe autostarts every time that I open a player widget, since XW is playing though WMP, right?
Is strange because all work ok since now...
Something stupid is happened..
Let me shutdown the system to clear any possible "shit" that the windows and WMP load.

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

this is not a bug of Xwidget
the problem is you doesn't set %tag in the checkbox binding, so it doesn't check the state of mute

Nothing man...My XW player widgets are not working any more.. Seems that XW player loads a certain location that can't be recognized..(?) Even when I add a song from the default windows music test tracks, nothing is playing..
I think that I have to uninstall XW, delete all its folders and re-install...I don't know..
There is a way to delete any temp files that the XW's playback engine use..?

I don't want to bother you with this... Let me try to fix it and then we will continue the project...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

you can:
1. set player program
2. visible/invisible player program
3. set CloseOnExit
> in Settings of playerControlCore (!ShowSetting)


no need to restart, just endprocess wmplayer.exe in taskmanager

edit:
Important:
if you're running a widget with playercontrolcore, first you should close that widget
because if it running it will restart the player on each taskkill


edit2:
the default player is wmplayer
and it starts in background (invisible)
you can open the player in windows to see its window while it's loaded in background

The fact hamid is that I have already did all this and I never changed any default settings! Until today that I tried this one, ALL work fine with player widget and I NEVER had this problem..! The "wmplayer.exe" starts automatically when press play on the widget and automatically ends/disappears when close the widget.
Some else is happening...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

this is just a player control core and not a player core
it just control the player that have been assigned with it to do the commands
and gets the state of player on each update

the default is wmplayer and you can change it in settings of your widget when you run your widget


you can even run the player and after that run your widget to control it

Hey bro..Thanks but I already know all this..
And I repeat, I NEVER had issues with XW and player widgets! I don't know why but these widgets don't work AT ALL any more!
I made a fresh installation of XW but the problem exists.
The fact is the playercontrolcore is the the core with the more bugs and is one of the things that Tony must re-create from the scratch..
I'm trying to fix it...
.............................................

Exactly what I notice: The widget is loading two specific tracks from my pc and when press "play" the buttons,progressbar doesn't work, doesn't play anything. Even when I add other song, only shows/loads the same track but actually not play anything..
Close the widget, restart XW, reboot windows, the widget always load the same stupid track..
I will try to ask help from qiancang and Tony if they know what causes it...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

ISSUE TOPIC OPENED:
viewtopic.php?f=3&t=4753

...and solution found it!!!
Damm stupid WMP..!

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

What's new:
1) Increased the height of the progressbar and add handpoint cursor for more easy control.
2) Added "%IsMute" tag so the system's volume status is recognized from the widget.
3) Changed the Roundline/Volume/mouse wheel tags to control the player's volume instead of the main system's volume.
4) Added "hint" text with mouse over the top and mute buttons.
5) Added a virtual button over the disc. Double click anywhere on the disc to "Add Song" dialog.
6) Added right click option "Close Player"

Issue (from the big cpu values I think):
XW engine can't load properly the "playtime" and the "progressbar" so they appear "frozen" and don't update.

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

for playing time & progressbar update:
set the playerControlCore update time again and the problem will be solved
i think 1000ms is good for it


problems:
1. volume percent doesn't update (you didn't change it to playercontrolcore)
2. mute Checkbox: have conflict with update tag
>since we couldn't disable the onclick changing of checkbox we should use another object for it


question:
what does Button Object with tag included do?
does tag has any effect on it? (changing caption, icon, enable/disable,...)?
found it myself
it will change the button image
so we can use button image with mute tag instead of checkbox object
you can rename the images to true&false and place them in a folder named mute

Of course! But why the resresh interval was changed by itself to 10 min???


1. Fixed
2. The problem is also with the playercontrolcore, the roundline component, the %volume and the !VolumeUp/Down mouse wheel tags that are not recognized. In the other hand with the main volume tags works ok.
Look, for this part I will assign the main volume again. As I told you there are a lot of mini bugs and there no need to break our heads for such a small thing!

About the mute button, all this time I study many widgets and on player widgets I have never saw the "%IsMute" tag assigned for this button. So let me return to the main volume setting that we're sure that will work!
Now, the possibility to load the widget with mute on is rare...

I'm uploading the fixed widget..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

1. i edited my previous post, read it again
2. for playerControlCore update: it's not 10min, it's 10ms, the text below it will show wrong numbers below1000 as "min" instead of "ms"
3. for mute problem: just change the checkbox object with button object and the problem will be fixed

1,2. Fixed the playing time & progressbar update.

Yes I mean 10sec not 10min.. I don't know why the default value was like this though...
2. Assigned again the main volume function for the roundline,mute and volper function.

The fact is only with checkbutton we can have the alternation of the two images/states! I tested with button making combinations and the doesn't work.
Just leave this part bro..It's really a small detail..

The next and the final thing to watch is the cpu...
I will post a another test replacing the image to animatedpng for the disc to see the difference.
I need your help here changing the script for the disc to this function: OK...?

onplayback=animatedpng play / stopplayback=animatedpng stop

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

With animatedpng for the disc:
The script needs your mod...
I put Interval(MS) for the animpng 80.. Bigger value will show up a buggy rotation..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

i mean millisec, not sec and min, the problem is with Xwidget showing wrong comment below that edit box in the core, anyway,

why do you use main volume again,
the problem will be fixed by a button,
i'll fix them myself and post it here,
plz wait...

Hamid as I told you only with checkbutton we can have the alternation of the two images/states!
I did it and tested with button making combinations and the doesn't work.
Now, if I'm missing something...
But I repeat. I think is not a big deal....!

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

this is just a test version:

i'm still working on it,
plz wait...

===========
[Changes]:
1. Changed: mute CheckButton to Button Object
2. Changed: play CheckButton to Button Object
3. removed: VolumeCore
4. Changed: pnganimate1 name to disc
5. Changed: sorting of some objects in widget tree
=============

now the problem is shadow doesn't work with icon changes
can you add shadow to the original images (play,pause,mute,unmute) instead
also tooltip text will be hide after icon change, but i don't think it would be important

edit:
i have used play&pause vice versa
i'll update it in next test

But why??? The checkbutton is actually used for this reason and worked 100%.
Why complicate more the things that work fine...
- shadow problem
- play stop images should be otherwise. During playback should show the "pause" button
- cpu usage has the same values..Maybe the animation ia bit smoother but the cpu is still high..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

Problem with CheckButton is:
1. it has a onclick changing behavior by default and couldn't be disabled
> so if you click on it it change its icon even if the change to the core failed
2. for most of the objects, when you add a binding tag for them, the original properties will be disabled and doesn't make conflict with each other
> but for CheckButton, it doesn't disable the original behavior, so both works together and make conflict, this means when you click on it, your click change it 1time and also at the same time binding core will be checked for new state and change atate of it again;
>>so if you add a binding tag to it, you will see multiple time changing for it
>>if you don't add binding tag to it, you wouldn't see the original state of player

i hope there would be an option in CheckButton to disable state changing by click

I think that my mind will blow up with the explanation but ok!
But this part need to be fixed:
play stop images should be otherwise. During playback should show the "pause" button
Pause = true , Play = false
I can edit the prev,next,play and pause images with GIMP and add shadow so all will have the same look and we'll not need the designer's shadow option..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

i didn't understand why you add pnganimate
i just renamed the object to work with previous code
and i just found that it has rotating animation inside it
did you mean to this property to be enabled in code?


and about play/pause i have mentioned in previous post
i thought that it's %play when renaming
and just didn't test it after naming
i'll update it in next test

Yes.. First I wanted to check the cpu behaviour changing the component from "image" to "animpng", and second, since in both modes the cpu is high, I think that we should add a right click option to switch on/off the disc animation..

Yes I saw that you didn't test it. I just told you for the next test file..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

Sorry again...
if you still didn't add shadow for images, it will works using image object
also using image object hint updating will be fixed
just we need to use glowOnMouseEnter animation for it to create mouseover effect like a button

and if you did the shadows, then no problem,
it will use less resources that way

I did it.. Here are the buttons with shadows. Just replace them and uncheck the designer's shadow option...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

i have created a new test to see the updates:

==========
[Changes]:
1. changed: the code for pnganimate rotate
2. changed: all button objects with image objects
3. changed: replaced all hintBoxes with one hintBox and add the code to link all of them to it using TagString
4. Changed: arm speed to be a bit sync with playing sound
5. Removed: Extra TimerCores and changed the code to be worked with only one TimerCore
==============



edit:
again, i have renamed the new play/pause images vice versa while adding new ones
i'll update it in next test file

OK....

Two things that I would like to change:
1) The mouse over glow effect color/intensity
2) Change a little the angle when the arm is open (is a bit to close to the center of the disc)
But these are pure design parts and easy to edit..
For the rest, when we will rename the play/pause buttons, all seem ok mate!

You have any other things in your mind..?
About the right click option for switch on/off the disc animation..?

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

ok, i think my work is finished
here's new test:

=========
Changes:
1. Added: code for arm movement while playing and menuitem for enabling/disabling it
2. Added: Menuitem and code to change the disc type to: [Normal,Mini,None] for lower cpu usage
3. Added: Border to Disc Object to remove bad shape around the miniDisc
4. Added: CoverBox to widget
5. Added: more HintBox text for more items: play,prev,next,rating
6. removed: image object for adding new file (Added event to the upcover image object instead)
7. Added: glowOnMouseEnter effect to Upcover
8. Changed: prev&next from button object to image object to be compatible with hintbox
9. Changed: file names and structure in widget folder
10. Changed: Optimized the code to use less resources and make the speed to be more realistic
============

i have done my works
if you don't want something (CoverBox,DiscType,DiscBorder,upcoverBorder), you can remove them
also i don't know if it needed to add hint text for other things or not

first i wanted to add OnMouseEnter/OnMouseLeave for CoverBox Object to show/hide a big CoverBox in somewhere (maybe on top of Disc is good)
but finally i didn't dicided to add it or not
if you want you can add it to widget

Ok bro! Let me test it and I'll reply..

Edit:

I think I will remove this..
For the rest I'll edit the glow mouse over color/intensity, the board and maybe the position of the CoverBox.

Important:
The arm movement should be from the other side, like in real life, from outside to the center of the disc.
Could you pls edit this part of the script?
(I was a kid of the 80's & 90's and I had an old skool player with vinyl discs so I know how it works.. )

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

but as i know any Disc even gramophone will start from center and end in outside
i don't know which device you have used
let me search for it to find some info about it

No man... Trust me..!
http://www.youtube.com/watch?v=UUmsWJ10kqI
http://www.youtube.com/watch?v=DD74OUDahEM

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

ok, you were right,
so it shouldn't get back to start position (RotateAngle=0) after finished disc?

No this is ok! After finished disc the arm automatically turns in 0 angle position.
You need only to change the during playback movement..

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

ok, here's new one:

=========
[Changes]:
1. Added: FullCover to be show/hide when MouseEnter/MouseLeave CoverBox
2. fixed: the code for arm movement Direction on Disc to Out>In
3. Changed: the code for Arm Speed and start,End position of it
=============

Ok! Now it's perfect!
I will do some small design adjustments and I will post it as sson as possible..
THANKS A BUNCH hamid!

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

plz add the option to close or show the player after widget closed
the player remains open and invisible after widget closed
maybe a rightClick option for user to choose afterclosing widget what to do:
1.Show Player
2.Close Player

Ok...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

One last thing hamid..
Is possible to add an extra right click option to switch on/off the disc rotation during playback to have even less cpu usage..?

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

i thought that the DiscType option is enough for it
but sure, i'll add it when you send the next test

The fact is that the "DiscType option" yes does the job, but with the "None" option the disc stops rotating but also the cover is disappear.. So I think that it will be better if we can have rotation off the cover visible..!

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

Since you wanted to remove some of the features,
i have added this as another version:

=============
Changes:
1. Added: MenuItem and code for Enable/Disable Disc Rotation
2. Added: MenuItem and code for Enable/Disable LargeCoverBox
3. Added: MenuItems and code for Show/Close Player after Widget Closed
4. Changed: widget Author Info in the script comment
5. Changed: Some Optimization to the code
=================

i'm waiting for your version to do the same to it

I think this latest version it's perfect hamid!!
One thing that I will change is on this part (I will change the numbers 1<->2 and the right click tag number)
because I think that it will be better the "close player" option as default.


So I'll do some little changes on the design and I will post this as the final version...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

if you want to change the default option for OnCloseMenu,
you just need to change 1>2 on (line14):

so it will get thisway:



i have used show player instead of close player, because:
1. player will be closed even if it has not been opened by widget
2. the user may be in the middle of some work and then the widget get closed and will lose any work in progress in player

but anyway, choose your own

Thanks again @hamid for the suggestions and your hard work...

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

Here are the changes that I made:
- Change the script for "Close Player" as default option
- Remove the mouse over offect from the upcover
- Change the Glow mouse over color to black
- Add an image/graphic under the small DiscBoxCover to give better visuals.

..posted:
viewtopic.php?f=11&t=4787

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

i used another widget and while i was using it i saw that it will close the player automatically after widget closed (without close command)
i don't know why it doesn't close the player while i testing our widget

so there should be a OnWidgetClosed>DoNothing option in menu
i was thinking to add it at first, but i don't know why i don't
so replace this one with that, if you think it's necessary

===========
Changes:
1. Added: menuitem and code for OnWidgetClosed>DoNothing to don't force to do anything on colse
===============

Ok.. I will replace the uploaded file..
Thanks

_________________
...and remember: don't take life too seriously...
My profile on Deviantart: http://jimking.deviantart.com/

CLEAN Player is awesome! My favourite widget. Regards to JimKing and Hamid.

One request: Is it possible to make it compatible with MusicBee? I would really appreciate this option. Hope it can be possible!

you can change the player in-use from the settings on the widget,
it can be accessed by using the Settings button on the right side of widget,

these Settings is related to Xwidget's PlayerCore and not this widget itself,
so it will work if Xwidget support that player

Thank you for your reply, Hamid!

Unfortunately, it doesn't seem like XWidget supports MusicBee. Too bad.